Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotency should only be added for :post #734

Merged
merged 3 commits into from Jun 20, 2022
Merged

Conversation

snewcomer
Copy link
Collaborator

Idempotency should only be added for :post. Stripe API is organized around REST and based on the HTTP spec, PUT and DELETE are idempotent. An idempotency key is only needed for POST.

close #711

docs https://stripe.com/docs/api/idempotent_requests

All POST requests accept idempotency keys. Sending idempotency keys in GET and DELETE requests has no effect and should be avoided, as these requests are idempotent by definition.

@snewcomer snewcomer merged commit 18a491a into master Jun 20, 2022
@snewcomer snewcomer deleted the sn/limit-idempotency branch June 20, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retries with delete subscription
1 participant