Add back Subscription.delete
#753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inooid
commented
Sep 22, 2022
Comment on lines
+108
to
+110
|
|
||
| assert {:ok, %Stripe.SearchResult{data: subscriptions}} = | ||
| Stripe.Subscription.search(%{query: query}) | ||
| Stripe.Subscription.search(%{query: query}) |
There was a problem hiding this comment.
鈩癸笍 Seems that these changes were done by mix format on this file 馃か
snewcomer
approved these changes
Sep 25, 2022
|
@inooid Mind bringing in the latest with a CI fix so we can get this PR green? |
|
@snewcomer for sure! I am currently feeling a bit under the weather, so if you feel like it needs to be wrapped up asap then please go ahead and make another PR to update it by yourself 馃憤 If you want to wait until I am recovered (hopefully next 1-2 days 馃) I'll wrap it up myself 馃憣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that with the Stripe API version upgrade we accidentally deleted the way for subscriptions to be cancelled.
The Stripe API docs (and their SDK) still mention the
subscription.del(). This PR is just a recovery of the previous version&delete/1,&delete/2and&delete/3methods (minus the deprecated params).Note: I have stripped off the deprecated params as they are also not referenced in the docs anymore 馃憤
Fixes #750