Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make request_id a string instead of tuple #763

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

mattnenterprise
Copy link
Contributor

The request_id in Stripe.Error was being set to a tuple that represented the "Request-Id" header. Now it will instead be a String like described in the typespec.

The request_id in Stripe.Error was being set to a tuple that
represented the "Request-Id" header. Now it will instead be a String
like described in the typespec.
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snewcomer snewcomer merged commit 651a6ce into beam-community:master Feb 17, 2023
snewcomer pushed a commit that referenced this pull request Feb 17, 2023
The request_id in Stripe.Error was being set to a tuple that
represented the "Request-Id" header. Now it will instead be a String
like described in the typespec.
snewcomer added a commit that referenced this pull request Feb 17, 2023
* Cleanup README

close #780

* Make request_id a string instead of tuple (#763)

The request_id in Stripe.Error was being set to a tuple that
represented the "Request-Id" header. Now it will instead be a String
like described in the typespec.

---------

Co-authored-by: Matt McCoy <mattnenterprise@yahoo.com>
nkezhaya pushed a commit to nkezhaya/stripity_stripe that referenced this pull request Feb 17, 2023
The request_id in Stripe.Error was being set to a tuple that
represented the "Request-Id" header. Now it will instead be a String
like described in the typespec.
@yordis yordis mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants