Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Code #444

Closed
wants to merge 3 commits into from
Closed

Refactoring Code #444

wants to merge 3 commits into from

Conversation

beanbeanjuice
Copy link
Owner

@beanbeanjuice beanbeanjuice commented Jan 26, 2022

Description

This improvement includes refactoring code and making it more readable. The end goal of this is to make it possible for all unit testing to work.

Fixes #443

Type of Change

  • Bug Fix (Small Non-Code Breaking Issue)
  • Bug Fix (Critical Code Breaking Issue)
  • Feature (Something New Added to the Code)
  • Improvement (Improving An Existing Section of Code)
  • Documentation Update

Changes

  • Internal Code
  • Documentation
  • Other: _____

Test Configuration:

  • Hardware:
    • CPU: AMD Ryzen 7 3800x @ 4.4Ghz
    • GPU: Nvidia RTX 3080
    • RAM: 32GB DDR4 @ 3600Mhz
  • SDK: Java Oracle 16

Checklist:

  • The code follows the style guidlines.
  • A self-review of the code was performed in GitHub.
  • Appropriate comments were added in the code.
  • Appropriate changes have been made to the documentation.
  • Appropriate changes have been made to the README.md file.
  • No warnings are produced when the code is run.
  • Appropriate tests exist for this pull request.
  • New and existing Gradle CI tests have passed.
  • The pull request is properly merging into the correct branch.
  • All existing local code has been pushed to the GitHub repository.
  • Changes have been documented in the current draft cafeBot Releases update.

@beanbeanjuice beanbeanjuice added the improvement Something to improve the current code. label Jan 26, 2022
@beanbeanjuice beanbeanjuice self-assigned this Jan 26, 2022
@beanbeanjuice beanbeanjuice deleted the 443-refactor-code branch July 1, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something to improve the current code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant