include zero in line charts for area mode #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to get an understanding if a change in an account
is big of small compared to the total of the account.
For example:
Small change but looks like very big change
300 :
: xxxxxxxxxxx
: x..........
: x..........
: x..........
: x..........
:xxxxx..........
250 :_______________
Small change looks like small change
300 :
: xxxxxxxxxxx
:xxxxx..........
:...............
:...............
:...............
:...............
0 :_______________
for more information, see https://pre-commit.ci
|
Yeah, I think this is also a nice way to address this and have both options :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the area mode in line charts always include zero. So that the area is not cropped.
In line mode the old behaviour (show 5% below lowest value) is kept.
This makes it easier to see how big a change in an account is in relation the the account size
Line
Area
