Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic-Module-Name #138

Closed
bjansen opened this issue Mar 19, 2021 · 3 comments
Closed

Automatic-Module-Name #138

bjansen opened this issue Mar 19, 2021 · 3 comments
Milestone
3.0.0

Comments

@bjansen
Copy link
Collaborator

bjansen commented Mar 19, 2021

Provide an Automatic-Module-Name in MANIFEST.MF to suggest a Jigsaw module name for projects that use JDK9+.
@bjansen bjansen added this to the 3.0.0 milestone Mar 19, 2021
@krisbanas
Copy link
Contributor

Hi @bjansen, can I take this issue?
I just need to know what name you want to use. I'd suggest simply going with beanio - is it OK?

@bjansen
Copy link
Collaborator Author

bjansen commented Sep 3, 2021

The general consensus regarding module names is to use reverse-DNS names. I'd prefer having com.github.beanio instead.

@krisbanas
Copy link
Contributor

PR ready for review!

bjansen added a commit that referenced this issue Nov 4, 2021
@bjansen
Merge pull request #142 from krisbanas/feature/138-automatic-module-name
693508f 
#138 Added an Automatic-Module-Name to the Manifest
@bjansen bjansen closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@bjansen @krisbanas