Guard against empty text TemporalAccessorTypeHandler #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add the corresponding unit tests in |
Implements similar logic as in https://github.com/willsoto/beanio/blob/c4e032b8e163c232cfc5f018ad961d4343022cc7/src/org/beanio/types/NumberTypeHandler.java#L50-L52 to return `null` in case the value to be parsed is `null`
|
@bjansen Done! |
|
@bjansen do you think you will be able to cut a release with this fix in? Not sure what other changes you have planned but I would like to have this bugfix included |
|
I'm waiting to see if #147 can be merged soon, otherwise I'll release 3.0.0.M3 with your fix only. |
|
I just released 3.0.0.M3 with your fix, it should be available on Central in a few minutes. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements similar logic as in https://github.com/willsoto/beanio/blob/c4e032b8e163c232cfc5f018ad961d4343022cc7/src/org/beanio/types/NumberTypeHandler.java#L50-L52 to return
nullin case the value to be parsed isnull