Add 'setClassLoader' with argument 'forceClassLoader' #570

* implement the JDK7, aka project coin, number literal additions * add binary number literals ex. 0b010101 * correctly parsing and processing underscores in numeric literals

WeakHashMap would either loose or not correctly set the namespace in multi thread conditions. Instead lets use ConcurrentHashMap and manually remove the entries on retrieval.

It was not implemented anymore so remove it.

Removed in favour of JSR223 support. BSF engine moved to external module bsh-bsf-engine for anyone that might still require it.

The field attribute is not serializable so when writing object we drop the field and retain the declared class, when needed again we fetch the field from the class again.

* test is successful if we remove the assert(false); * removed additional junit test not required * remove as known issue

* rename to BshScriptTestCase and inner class TestBshScript to Script * add Script constructor for String filename in test script folder * simplify setting interpreter "bsh.cwd" variable * properly allow Fail.bsh to fail and assert expected error * add ability to skip tests based on assumptions

We'll assume we haveAccessibility before attempting to test illegal access, this will skip these tests if accessibility=false (default)

In some cases static imports were failing now we look for the class first before leaving it to Name to try and resolve.

Even with setAccessible package private constructors and methods were failing, we now make constructors and methods without modifiers public and super delegates are public by default as they will have any additional modifiers applied when calling the super method.

JDK8+ does not have rt.jar anymore so we just add an empty boot class path. load command does not need to setAccessible anymore. compile and run tests with accessibility=false (default) now succeeds with --illegal-access=deny with Java 9 or Java 10

It is not clear what was originally intended with this script it fails for lack of a default constructor on the anonymous class. The current state of anonymous class capability is uncertain and since this is called classinner and not classanonymous I added something more appropriate to test for. Grouped some more scripts with the InnerClassTest test case for reference.

This test was failing on the if statement Capabilities.classExists("bsh.ExternalNameSpace") for some reason. Added a static import and changed the if block to an assume and all the asserts passed. Refactored the test to use junit asserts seemed more appropriate.

* removed some commented lines * ph-javacc-maven-plugin version 4.x uses the new javacc fork ParserGeneratorCC see https://github.com/phax/ParserGeneratorCC * TokenMgrError was made redundant by ParserGeneratorCC so we remove it as well * added bsh.debugClasses as a system property for specifying the location to save generated class files.

* for null type we give preference to String, then most specific non primitive which is not an array, then arrays * less specific is assignable by most specific unless signature is a match * improved varargs matching no argument or null type as vararg * known issue RefectTest.findMostSpecificSignature elaborated and resolved

* added some reusability improvements to testUtil * renamed and redistributed issue_XX tests to more intuitive names.

Collected from generically named unit tests.

Only contains the switch string statement now.

* added new grammar for try TryWithResources and AutoCloseable * implemented BSHAutoCloseable as a subclass of BSHTypedVariableDeclaration to reuse the variable evaluation. * BSHTryWithResources acts as the collection of resources and interface for evaluating and closing the resources. * added a lookup for 1st Block node to BSHTryStatement to avoid the use of magic numbers * on eval start if the 1st Node is TryWithResources we keep a reference and call eval which will create the variables in the namespace in callstack * in the finally block of the try block evaluation, if we have a reference to BSHTryWithResources we auto close, which ensures that all resources are closed. * suppressed on close exceptions will be collected in the target exception from the try block

* Infer a collection of parameter names and set a collection of parameter modifiers for the BshMethod wrapped java.reflect.Method delegation.

Java 9/10 handles the close exceptions differently to JDK 8, with the latter the exceptions thrown on close are the same instance as the target exception with suppressed exception already collected. With the newer versions you have to add the suppressions manually.

* add grammar to parse multi catch * implement evaluation of catch block with a list of types * improve check assignability to avoid the previous try fail catch continue manoeuvres * enable ability to throw throwable and subtypes - previously limited to exception types only * added some simple multi catch tests

We are loosing state because some nodes don't have modifiers.

* remove redundant use of token variables * remove redundant comments * some styling ease of readability

default behaviour ,regardless of accessibility, if no access modifiers (or package private) bsh default is public visibility

* validate abstract methods are implemented or class declared abstract * bsh classes are virtual abstract only or iow abstract classes can be instantiated * apply inheritance rules overridden methods may not reduce visibility

* added grammar to parse default as modifier not to be confused with default: as switch token * implement interface static methods, only accessible on interface * implement interface default methods, inherited by class, overridden by class or interface extends, accessible as class instance method * added interface methods unit tests

* added option to test evalError contains message * some modifications utilising new junit asserts

* correct preference for choosing overridden method based on class hierarchy * fix bug loosing correctly chosen class method * fix initialise class instance This and instance init for calling overridden method from super constructor * fix inherit loose-typed class instance fields * added new tests and unmarked the last known issues as working

* improved handling of no rt.jar availability

remove reference to java,awt.Button.

@daudich

* as reported by @daudich issue beanshell#67 * nested instantiations caused long parsing time due to excessive syntactic lookahead * modified grammar and applied changes to the node parsing * added unit test performance down from 10s to 0.5s

* Once the class has been generated fields will be referenced from the class, doing it here retains the modifiers state.

* find classes in module java.base via jrtfs file system * modified jar search for rt.jar via file system provider

* added unit test for auto closable validation check ensuring that try with resources implement autoclosable. * minor tweaks to try with resources implementation

* made it possible to release interpreter resources by implementing autocloseable with the ability to close in, out, err resources. * added additional tests for script engine with enhancements and code cleanup of the implementation * added default UTF-8 character encoding support for the WriterOutputStream wrapper class * improved script context engine view map wrapper and reduced duplication * removed impossible exception catches from script engine

* address all resource leak warnings and appropriately close and release Closable resources

Caused some false positives with the truthy returns, instead look for falsy.

* Implemented BigInteger and BigDecimal * coerce number narrowing within range while maintaining type safety * fixed illegal assignment of value pre cast exception * refactored Primitives * implemented all operators with unit tests * add power ** and power assign **= operators * improved number operations and assignments * refactored number literal parsing

* added a typeString method to get the type from a value, checking null, Primitive and class name. * added another methodString function to build method from value args.

By taking regard of the state of Thread.interrupted() loops can recover quicker if their threads were interrupted. Also let interpreter assume it was restarted if it is interactive and has a parent there's no need to print the banner again.

being able to implement interfaces without implementing abstract methods could be considered a language feature, lets only enforce abstract method implementation validation when strict java is enabled

…ethod

* incorrectly processed strings with octal number length == 3 and chr(0) > 3, should revert to number length == 2 * ensure char octal <= 255 as larger numbers than 377 may produce valid chars * added unit tests for proving beanshell#25

* classes now referenced by name * check if name exists and prevent additional class not found exceptions * complete code coverage for capabilities

- added more history including beanshell2 for - add development roadmap - added projects using beanshell

use StringBuilder wrap String values in double quotes and char values in single quotes use simple names for java.lang classes use simple names for BigInteger and BigDecimal

Make enforcing static interface method accessible on declaring interface class only, strict java

* Apply additional type suffixes as follows * * byte (octet) o or O * * short s or S * * int i or I * * long l or L * * BigInteger w or W * * float f or F * * double d or D * * BigDecimal w or W * Protect type overflow when casting, allow casting wrapper types, apply default value to wrapper types initialise default value in wrapper type arrays. * Added chars identifiable as number with all the casting magic, overflow protection and goodness. * bytes have been extended to allow unsigned 0 to 255 or 0xFF as max value and -128 as min value. Cast byte to int assumes toUnsignedInt automagically, -1 becomes 255, -127 becomes 129 etc. * fixed numeric type comparison, new BigInteger("5") == 5.0f or Long.valueOf(10) == Byte.valueOf(10o) etc. * added scratch variables, 10 variables named $0 to $9 are automatically assigned the last return value, improved show results prompt. * StringUtils extended to decorate the numeric type values with type suffixes and handle multi dimensional arrays.

update UndeclaredThrowable use was replaced by getCause update exception message wording

includes support for switching enums as requested beanshell#31

Moved all the generated class runtime support methods to This.class, seems more appropriate. Nothing added or removed in this commit.

as per stefanofornari/BshConsole#2 EOF parser exception can only occur in interactive mode when interpreter is interrupted (Ctrl+C) during multi line input, since this was a user decision there is no point complaining about it.

Since we are minimum JDK 1.8 and with modern javacc these legacy work arounds are not required anymore.

Target errors nested were not properly unwrapped. Removed the need for referencing both target and thrown and other small clean ups.

Fixed 1 test asserting for \n but translated to windows \r this is now trimmed before compare Mark 1 test as known issue unicode comparison failed Can now successfully compile and run Tested on Windows 10 with both JDK 1.8 and Java 10

Ensure that we are comparing apples with apples.

Tests for BshClassPath coverage and to ensure rt.jar or equivalent gets loaded.

Add additional unit tests.

In byte code when building the args array instead of having to loop the args again in This.invokeMethod. Logically order the primitives.

Made Interpreter.DEBUG ThreadLocal to play nice with others. Improved Interpreter.debug prompt method to use varargs and StringBuilder. Normalised usage and removed redundant if (DEBUG) checks when calling debug prompt.

Made accessibility a singleton for assigning an initial value via consumer supplier functions. setAccessible will now be thread safe.

Caching the prompt is not useful when we are externally expecting the to be called.

Don't close System.out or System.err. Make EOF an instance variable, set true on close and allow thread yield, using Thread.sleep, on parser exception to wait for closing. Make console null and avoid null pointer exception if printing after close. On eval enclosing interpreter might share local reader, avoid auto close.

From millisecond time to nanoseconds as the former only reported 0.

Moved getClassStaticThis and getClassInstanceThis from This to Reflect.

Before all classes were treated as non static inner classes and local classes didn't get local variable scope. Now static inner classes only have static scope, inner classes and local classes have static and instance scope of outer class and local classes have method scope.

use string split instead of string manipulation (indexOf, substring). lazy build compounds as needed. weak reference cache name compounds build only once. completed unit tests.

* Fix equality at Primitive.equals as well as operators * Fixes to castNumber ** removed redundant checkonly which cannot exist with fromvalue and we need the value for castNumber. ** return the number instead of Primitive, rather wrap on demand than having to unwrap needlessly ** removed BigDecimal reference requirement and parse string number operations ** optimise constant zero and one assessment * abandon shrink to float minimum, turns out the loss in precision is significant. back to default floating point data type double... as per java. see beanshell#71 * cleanup and fixes to BSH nodes BinaryExpression, UnaryExpression, Assignment (operators implementation) and Literal. * refactor, relocate methods Type lookups isNumeric, isFloatingPoint, isPrimitive * additional primitive unit tests including floating point precision analysis

This allows a better integration with console libraruies which usually manage the prompt on their own. It seems to be a functionality closer to the responsibility of the console rather than the interpreter.

…an apply specialized logic.

…lementation

Instead of using the namespace.

Ahh hasModifier lookup for java method.

…ell#79 Implement inner class Console for resource management. Drop ConsoleInterface implementation for interpreter. Delegate public methods to console instance to be non breaking. Removed stream references and related class variables. Improved target error output for isNative stack trace.

Remove default import of java.awt and javax.swing classes.

…tring.

Added Primitive zero value as constants and improved typed default value allocation.

Removed the need for collecting a list Added more values() unit tests

Extracted Types.getType method implementation. Remove all instanceof Primitive cast and getType duplicated code replacing it with Types.getType.

Replace primitive widening rules with number order list implementation. Implement basic finding of a common type between two classes.

Remove Reflect.normalizeClassName replaced with StringUtil.typeString Remove Reflect.getArrayDimensions replaced with Types.arrayDimensions Remove Reflect.getArrayBaseType only used by normalizeClassName

Refactored operators for arbitrary objects and consolidate duplication in BSHAssignment and BSHBinaryExpressions. Implemented array and list concat + and repeat * operators as introduced at beanshell#89

Added functionality to cast array to the element type which iterates over all dimensions and casts the value elements to element type. Also adds the ability to cast array to List, Queue, Deque, Map and Map.Entry collections.

Implementation of the array slice functionality introduced at beanshell#89. Refactored set and get Index methods moved to BshArray class.

Implementation of loose typed arrays with inferred dimensions and inferred type. Also includes many fixes to the expected java usage which was broken previously. Includes new map expressions and support for collections as introduced at beanshell#89

See beanshell#89 for more details...

Reusing some of the new functionality added with improvements in particular to the varargs implementation.

Remove unused, redundant and implied code.

Sort projects alphabetically. Leave the history towards the end and adopt reverse chronological order. We are focused on the future now ;).

It corresponds to the LICENSE file.

…ications.

Great job nickl- !

@opeongo

As reported and assisted by @opeongo Find the super constructor for the supplied arguments. Add super constructor as constructor for anonymous sub-classes. Create BshMethod from reflect constructor. Refactor This.getConstructorArgs with methods extracted to DelayedEvalBshMethod for finding first statement method invocation.

Use class name .class in byte code instead of Class.forName. Fix some spelling mistakes and error messages in This.getConstructorArgs

Enables bean property access consistently for object instance an class static bean properties. Correctly imports object or static bean properties as variables. Ensures private members are not imported or accessible. Ensures bean accessor "is" methods are only applicable to boolean properties.

The .jj grammar definition gets auto generated from the .jjt JJTree grammar definition and is not needed anymore.

Fixes beanshell#426 When AllocationExpression with Ambiguous name appears as MethodInvocation argument the method fails to be identified. With a more specific context we were able to hit the target with more accuracy. This also improved the token manager errors being closer on target. With the shorter context this will also improve parser performance.

Inherited from the standard java grammar when processing expressions we had to create 17 tokens one for each of the operators, this has now been reduced to only 4 which should give a performance bump but significantly reduces overall grammar complexity. Productions used before ConditionalExpression, ConditionalOrExpression, ConditionalAndExpression, InclusiveOrExpression, ExclusiveOrExpression, AndExpression, EqualityExpression, InstanceOfExpression, RelationalExpression, ShiftExpression, AdditiveExpression, MultiplicativeExpression, UnaryExpression, PreIncrementExpression, PreDecrementExpression, UnaryExpressionNotPlusMinus and PostfixExpression. Reduced to ConditionalExpression, RelationalExpression, BinaryExpression and UnaryExpression. Also optimised the cast lookahead and cast expression removing several LOOKAHEAD statements..

Cache the default prompt string retrieved via eval("getBshPrompt();"); for interactive mode, to avoid having to evaluate the string on every command. Console ensures out and err streams are never null by returning default streams from System if not set.

@mod

Added missing overloaded document friendly operators @mod, @mod_assign, @pow, @pow_assign, @bitwise_xor an @xor_assign.

Fixes beanshell#425 Operator + does not always work with a null String Identify type of null values by retrieving their variables from the name space. If type is String and operator kind is PLUS turn null value into "null" string. If null value and null value value two and is kind EQ == or NE != and is comparable allow null values returned. If not comparable null values raise incomparable types error. If any value is wrapper type and the operator is valid operator for type throw null pointer exception. If not wrapper type or not valid operator cause bad operand types error. Apply wild card generic type to Class in Variable. Unit tests to proof...

Closed by commit.

Make numberValue throw runtime exception instead of checked exception. Add strictJava number cast without checking boundary constraints. Implementation of strictJava declaration fixes beanshell#455

@opeongo

As reported by @opeongo at, and fixes beanshell#495 Double escape \ \ and string or char quote escape especially with multiple literals on the same line would throw parser errors. Escapes are now ignored in char and string literals and redefined as 2 character literals starting with an escape and followed by another character.

@wiix

As pointed out by @wiix at and fixes beanshell#499. Extracted constant ACCESS_MODIFIERS the sum of all access modifiers public, protected and private, as defined in reflect Modifier but oddly not accessible. Also implements a simplified version of reflect gather methods recursive as that method is marked for deletion.

@pgiffuni

As reported by @pgiffuni at and fixes beanshell#490

Fixes beanshell#444 by including property cache, design as explained at beanshell#502 Also introduces additional property types Map, Entry an Entry[].

Fixes beanshell#504

…to doing the comparison remove any cr characters that may have shown up. This fixes a platform specific problem (along with the path separator) that occurs up on Windows and prevents the test suite from succeeding.

https://community.synopsys.com/s/article/Coverity-Scan-Update

It's in the repo history when we need it back.

…type

It should not be possible to concatenate void or undefined variables in strings.

For scripted objects that do not return a value void should be returned net null. Also bean properties that do not exist should return void

The scripting engine uses in/out writers from `ScriptContext` so we do not have to manage these resources.

BeanShell new version number 3.0.0 Group id changed to org.beanshell

JDK 9 method signature is different and fails on accessibility.

Method always returns true since everything is iterable. Added for loop return control tests for continue, break and return.

It appears to have something to do with the escaped new line string and the differently interpreted line endings.

beanshell#132.

Add test for method selection with null parameter - identified in Iss…

Added a notice pending the new release to inform everyone of current plans decisions. Updated roadmap, we can consider code coverage at 70% as a milestone reached.

Method always returns true since everything is iterable. Added for loop return control tests for continue, break and return.

Clear the evaluated nodes cache used to avoid redundancy when inferring types and dimensions for dynamic arrays. Fixes beanshell#513 which reported blocks using cached array values. Includes block tests for array, map, entry an collections.

Added unit test for bsh.engine.BshScriptEngine, javax.script.Compilable compile script and eval with context arguments to satisfy query raised under beanshell#528

Improvements to Node interface and SimpleNode implementation to finally move away from cast to SimpleNode spagetti. Added many useful functions for accessing and manipulating the tree with check safety as well as a complete ListIterator implementation for traversal.

Added more code coverage for SimpleNode.

Removed unreachable code. Added extra unit tests.

More examples for beanshell#528 exposing compiled methods for use by other scripts.

Added support for initializing List (and other Collection types) and Map with empty initializer expressions `{}`. Refactored BSHArrayInitializer and made some improvements to Types an BshArray classes. Include tests for empty initialization expressions.

Improved the bsh test script test suite runner's verbosity output and other optimisations. Adding the maven argument `-Dverbose=true` will output each unit tests duration and outcome.

@nickl-

Developer @nickl- added to developer list in pom.xml

Change javacc plugin configuration for jdk version to use project property instead of hard coded value.

Added default skip = false configuration for reference. Bind prepare agent goal execution to the generate resources phase.

With a completely new fix which now gets down to the actual problem by clearing the specific items that are being cached. Caching is the correct solution and there is also not any clean way around it, if we don't cache some values can be evaluated as many as 3 times and that will only spell disaster. 1. Infer the dimensions if they are not known The least amount of effort still requires to traverse the hierarchy of child nodes, looking at the first element element only, counting the dimensions. At the last element we need to evaluate the node because it may be null which adds an additional dimension in itself but this empty dimension allows for a subsequent dimension to increase the dimensions for example { null, {{{1}}} 2. Infer the common element or array base type if that is not known. This does require every element in all dimensions to be traversed and evaluated to obtain a type. Unless we have reached the common type Object.class there no aborting early because a bigger value than the common type we may currently know could still exist. This does leave very unpredictable outcomes of maybe all, maybe some and also maybe none. 3. Instantiate and populate the array With base type and dimensions known, which could've been specified, we can no proceed with a new array instance of type in hand coaxing all the values again to conform. Also managed a few other optimisations and clean up plus the unit tests for the edge case.

For some reason relative paths don't work anymore.

@orbitalair

As mentioned in the issue beanshell#534 raised by @orbitalair requesting support to source from `URL`. After investigation it was found that the `source` command did indeed support `URL` so the issue was closed. In a new discovery it was found that the `source` command and the interpreter `source` methods did not correspond. This patch now normalises the two locations and along with support for sourcing from `String` file name and `URL` we also added `File` capabilities.

This commit only updates documentation, some minor code style fixes and parameter name normalisation. This does not change any functionality.

It is more efficient to do the new line replacements on the shortened source string instead of before.

There is no point in creating the `new StringReader("")` instance for the standard input when it is not useful and will be changed from `eval()` anyway. Assign null for input stream and defer to eval to provide the correct input.

The messages were different for ArrayStoreException and NoDefaultConstructor on OpenJ9 jdk 8 but at least the types are equivalent so no harm done.

Removed some white space.

Don't use SimpleNode when a simple Node will do.

If possible ReInit an existing parser instead of initialising it from new. Inherit parent parser and if parent not interactive and there are no child nodes on the parser stack then we may reinitialise the parser. This will show a drastic performance increase to eval and other child Interpreters.

Instead of always using null parent constructor lets just accommodate a name only constructor too.

Added additional eval only constructors for Interpreter which uses the system standard output and standard error but defers input to be supplied by eval.

Refactored eval method to extract reusable method for terminating statement strings.

Simplified the implementation of the PreparsedScript class, simple interpreter instance apply class loader to interpreter, eval the script to retrieve the callable object and reference the prepared instance. On invoke create the scoped name space and local interpreter, set the context variables invoke the prepared script and unwrap the results. Added compound name resolution in context variable names. Standardised the source file info and do not reveal the wrapped method name. Added terminated script conversion to ensure statement is terminated fixes beanshell#529 Fixed unit tests and enabled multi threaded test, added additional tests to illustrate compound name resolution. Added serial garbage collector java vm argument to properly apply large eden algorithms which parallel gc will stall on. Added an empty map and a map of key value pair list helper to TestUtil for supplying tests with data maps.

Changes as per enhancements made to StringUtil for data type values to string. Fixes beanshell#527

Performance: O(1) Listener add/delete

Fix for beanshell#566 cannot concat assign null string.

It was not immediately clear what the purpose of checkNullValues was so refactored the implementation. Optimised if statements to release as soon as possible by finding most likely to fail first. Found and fixed bug with null comparison with wrapper types not working like Java. Now allows for comparing 3 states of Boolean types. Reduce operators required stack memory footprint.

https://central.sonatype.org/pages/apache-maven.html

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.10 to 8.29. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-8.10...checkstyle-8.29) Signed-off-by: dependabot[bot] <support@github.com>

…bsf-engine/com.puppycrawl.tools-checkstyle-8.29 Bump checkstyle from 8.10 to 8.29 in /bsh-bsf-engine

Commits on Jun 8, 2019

Less for more

nickl- committed Jun 8, 2019

Configuration menu

View commit details

Copy full SHA for b7ce43d

Browse repository at this point

Copy the full SHA

b7ce43d View commit details

Browse the repository at this point in the history

Commits on Jul 14, 2019

Performance: O(1) Listener add/delete

morris821028 committed Jul 14, 2019

Configuration menu

View commit details

Copy full SHA for 0ae2c1c

Browse repository at this point

Copy the full SHA

0ae2c1c View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'setClassLoader' with argument 'forceClassLoader' #570

Add 'setClassLoader' with argument 'forceClassLoader' #570

Commits on Mar 19, 2019

Commits on Mar 20, 2019

Commits on May 28, 2019

Commits on Jun 7, 2019

Commits on Jun 8, 2019

Commits on Jun 15, 2019

Commits on Jun 16, 2019

Commits on Jun 17, 2019

Commits on Jun 18, 2019

Commits on Jun 19, 2019

Commits on Jun 20, 2019

Commits on Jun 21, 2019

Commits on Jun 24, 2019

Commits on Jun 25, 2019

Commits on Jul 14, 2019

Commits on Jul 17, 2019

Commits on Jul 21, 2019

Commits on Oct 13, 2019

Commits on Dec 16, 2019

Commits on Jan 31, 2020

Commits on Feb 4, 2020

Commits on Feb 12, 2020

Add 'setClassLoader' with argument 'forceClassLoader' #570

Are you sure you want to change the base?

Add 'setClassLoader' with argument 'forceClassLoader' #570

Commits on Mar 19, 2019

Commits on Mar 20, 2019

Commits on May 28, 2019

Commits on Jun 7, 2019

Commits on Jun 8, 2019

Commits on Jun 15, 2019

Commits on Jun 16, 2019

Commits on Jun 17, 2019

Commits on Jun 18, 2019

Commits on Jun 19, 2019

Commits on Jun 20, 2019

Commits on Jun 21, 2019

Commits on Jun 24, 2019

Commits on Jun 25, 2019

Commits on Jul 14, 2019

Commits on Jul 17, 2019

Commits on Jul 21, 2019

Commits on Oct 13, 2019

Commits on Dec 16, 2019

Commits on Jan 31, 2020

Commits on Feb 4, 2020

Commits on Feb 12, 2020