Implementation for BeanShell 2 compatibility mode (issue #727) #728
Conversation
…ipts that use scoping rules that declare loosely typed variables in the outer (enclosing) scope.
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
============================================
- Coverage 74.16% 74.09% -0.08%
- Complexity 3039 3042 +3
============================================
Files 108 108
Lines 9357 9373 +16
Branches 1857 1860 +3
============================================
+ Hits 6940 6945 +5
- Misses 2074 2082 +8
- Partials 343 346 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| } | ||
|
|
||
| /** | ||
| @see #setBsh2ScopingCompatibility( boolean ) |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @see block as a summary fragment instead.
| @see #setBsh2ScopingCompatibility( boolean ) | |
| See {@link #setBsh2ScopingCompatibility( boolean )}. |
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/beanshell/beanshell/728.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/beanshell/beanshell/728.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
|
Closed as per #727 |
Implement a mode to allow backward compatibility with BeanShell 2 scripts that use scoping rules that declare loosely typed variables in the outer (enclosing) scope (#727).
Although this touches a lot of files, it is actually not very invasive. The active change is a few lines in NameSpace.java. The bulk of the changes are to change the implementation of the strictJava flag from a boolean to an int flag container such as argument passing and value testing.