Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for parsing long tokens #734 #755

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for parsing long tokens #734 #755

wants to merge 3 commits into from

Conversation

opeongo
Copy link
Contributor

@opeongo opeongo commented Jan 4, 2024

This PR patches the output from javacc to correct a bug that prevented the parsing of long tokens. The fix for the bug was submitted to upstream but has not been packaged up yet. Consider this to be a temporary patch until the fixed version becomes available.

tmoore added 3 commits January 3, 2024 00:48
- patch generated sources to fix upstream bug
- add test
This patch is temporary until upstream updates to a correct version
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b35aac4) 74.24% compared to head (8ecb06f) 74.26%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #755      +/-   ##
============================================
+ Coverage     74.24%   74.26%   +0.02%     
- Complexity     3042     3043       +1     
============================================
  Files           108      108              
  Lines          9357     9357              
  Branches       1857     1857              
============================================
+ Hits           6947     6949       +2     
+ Misses         2070     2069       -1     
+ Partials        340      339       -1     
Flag Coverage Δ
unittests 74.26% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant