OUT_OF_MEMORY after crash

[arp]

Updated steps to reproduce in v1.4.6:

$ mkdir x
$ ./beanstalkd -b x &
[1] 4369
$ kill -9 4369
$ ./beanstalkd -b x &
[2] 4371
[1]   Killed                  ./beanstalkd -b x
$ printf 'put 0 0 0 0\r\n\r\n' | nc localhost 11300
./beanstalkd: binlog.c:589 in maintain_invariants_iter: newest binlog has invalid 155 reserved
./beanstalkd: prot.c:841 in enqueue_incoming_job: server error: OUT_OF_MEMORY

$ 

The same sympoms can be reproduced when working with queue for some time and leaving it empty before crash. Non-empty queue replays nicely. So, generally this looks like a bug in replaying the empty binlog or something closely related.

[kr]

This should be easy to fix.

[kr]

Properly update the binlog linked list pointers.

Code in this file assumes that newest_binlog is always correct, so when
there is no binlog at all, we must set newest_binlog to NULL.

Closed by 70b63d5.

[MarkRose]

I also just ran into this or something similar after a server crashed and was rebooted. It had nothing in the queue at the time (the server isn't heavily loaded).