Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken File Permissions during Usage #4

Open
ragingdave opened this issue Aug 23, 2017 · 1 comment
Open

Broken File Permissions during Usage #4

ragingdave opened this issue Aug 23, 2017 · 1 comment

Comments

@ragingdave
Copy link

Perhaps a misconfiguration on my end, but this plugin has the possiblity of breaking file permissions.
For example, under a normal apache setup (files/folders owned like webdr:apache)
/var/www/html
|->test
|->test.php

Editing test.php, would cause the saved changes to be saved in a brand new file owned by webdr and owned by group webdr, completely breaking file permissions structure and normal operating procedure for VIM.

If it was a misconfiguration, More instructions are needed to ensure that this doesn't happen. Otherwise, this plugin is completely and totally unusable in normal environments.
KexinLu pushed a commit to KexinLu/vim-phpfmt that referenced this issue Aug 24, 2017
@kexinlubeanworks
Issue beanworks#4 Broken File Permissions during Usage
63962f2 
Cause: we make a copy of the file then format the copied file, but
this file's owner ship and permission are not preserved.

Solution: overwrite file content of current file directly
@KexinLu
Copy link

KexinLu commented Aug 24, 2017

Solution I provided caused other issue, will look into this a bit more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ragingdave @KexinLu