added Hungama.js for support of hungama.com #667
Conversation
Support for hungama.com
…ma.com Adding new file to MediaStrategies
|
Don't forget to update |
|
Sorry! I forgot to see that. |
| return { | ||
| 'track': getElementsByClassName("jw-songName")[0].innerText, | ||
| 'album': getElementsByClassName("jw-songAlbum")[0].innerText, | ||
| 'image': getElementsbyClassName("jw-albumThumb")[0].src |
There was a problem hiding this comment.
Change these to:
document.querySelector(".jw-songName").innerTextdocument.querySelector(".jw-songAlbum").innerTextdocument.querySelector(".jw-albumThumb").src
You have to include document. before each of those functions, querySelector(".class") is faster than document.getElementsByClassName("class")[0], and also these are capitalized correctly (the "b" in getElementsbyClassName was not capitalized for the image).
There was a problem hiding this comment.
Oh, I can't believe how I missed that, this is my first time, so stuff is going all over the place..
Thanks for being helpful!
|
👍 |
|
What about readme.md? Why nobody don't add new strategy in description? :) |
|
Yes, I forgot about that. Also beardedspice.github.io, but that must be done in a different pull request (maybe it should be retrieved automatically from this repo via javascript?) |
Reminds strategy makers to add their strategy to the list in `README.md`. See the [discussion on beardedspice#667](beardedspice#667 (comment)). This does not include updating `beardedspice.github.io` in [this list](https://github.com/beardedspice/beardedspice.github.io/blob/77f870b0e30f6392c2c5467319c32050f82b4740/index.html#L72) because that would require a separate PR for each strategy. I cannot think of a good solution to this other than having a bot update that list (or by using Javascript on the website).
No description provided.