Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update genie music #730

Merged
merged 3 commits into from Oct 20, 2017
Merged

Update genie music #730

merged 3 commits into from Oct 20, 2017

Conversation

kimtree
Copy link
Contributor

@kimtree kimtree commented Oct 18, 2017

Recently, Genie Music changed their player so I changed all source code for supporting new Genie Music player.

@1ps0
Copy link
Member

1ps0 commented Oct 18, 2017

Excellent, thanks! Will be testing shortly.

  • Passes Lint
  • Passes JS Load
  • Passes isPlaying
  • Passes play toggle
  • Passes all other implemented JS

*Looks like this site is region locked. Can I get an independent verification from someone who can access http://www.genie.co.kr/player

@kimtree
Copy link
Contributor Author

kimtree commented Oct 19, 2017

@1ps0 Hi, Thanks for responding. It seems that Genie Music doesn’t block access from outside of South Korea. The message says that the page not found. You can try with the correct URL as follows. http://www.genie.co.kr/player/fPlayer

@1ps0
Copy link
Member

1ps0 commented Oct 20, 2017

hah, go figure. Works great, thanks for the assist!

@1ps0 1ps0 merged commit 2d8269c into beardedspice:master Oct 20, 2017
1ps0 pushed a commit that referenced this pull request Oct 20, 2017
@1ps0 1ps0 removed the in testing label Oct 20, 2017
@1ps0 1ps0 added this to the 2.2.4 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants