Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ldap client errors visible to bluebird #3

Merged
merged 4 commits into from
Mar 17, 2017
Merged

Make ldap client errors visible to bluebird #3

merged 4 commits into from
Mar 17, 2017

Conversation

veronicapowersbeardon
Copy link
Contributor

No description provided.

aaronbean
aaronbean approved these changes Mar 16, 2017
View reviewed changes
Copy link
Member

@aaronbean aaronbean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veronica, it all looks good. Did you run into issues with these things, or did you just notice that they needed to be there?

@tyscorp
Copy link
Contributor

tyscorp commented Mar 16, 2017

yes

@veronicapowersbeardon
Copy link
Contributor Author

Yeah, when it couldn't make a connection with one of the clients it was throwing an error and crashing the application using it, so I needed a way to hook into the errors from the event emitter.

@veronicapowersbeardon veronicapowersbeardon merged commit d305765 into master Mar 17, 2017
@veronicapowersbeardon veronicapowersbeardon deleted the promise-error branch March 17, 2017 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbean aaronbean aaronbean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veronicapowersbeardon @tyscorp @aaronbean