Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typings to package #16

Merged
merged 5 commits into from
Feb 15, 2020
Merged

feat: add typings to package #16

merged 5 commits into from
Feb 15, 2020

Conversation

unional
Copy link

@unional unional commented Jan 24, 2020

Hi, @bearjaws ,

Thanks for making this package.

This PR adds TypeScript types to the package.
Please see if you would like to add it in.

I have made a slight adjustment in the test so that it can be used to check the types.
It will be beneficial down the road to help to detect any inconsistency between the code and the types.

All it does is change the reference point from ../lib/wget to .. to reference the package itself, and add the @ts-check comment at the top.

If you want, I can remove that change too.

Best

@bearjaws bearjaws merged commit 1241063 into bearjaws:master Feb 15, 2020
@bearjaws
Copy link
Owner

Thanks for this, I love typescript and think this will help others greatly.

👍

@unional unional deleted the typings branch February 15, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants