Skip to content

Commit

Permalink
#10 fix mysql readme documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
bearmug committed Feb 11, 2019
1 parent 0bc459c commit 891264a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ code-checks: compile
$(REBAR) dialyzer
$(REBAR) as lint lint

test: format compile
test: compile
$(REBAR) as test do ct -v

cover:
Expand Down
10 changes: 7 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Erlang ❤ pure database migrations
> PostgreSQL / MySQL version control engine. Effects-free.
> PostgreSQL and MySQL version control engine. Effects-free.
[![Build Status](https://travis-ci.org/bearmug/erlang-pure-migrations.svg?branch=master)](https://travis-ci.org/bearmug/erlang-pure-migrations)
[![Coverage Status](https://coveralls.io/repos/github/bearmug/erlang-pure-migrations/badge.svg?branch=master)](https://coveralls.io/github/bearmug/erlang-pure-migrations?branch=master)
Expand Down Expand Up @@ -201,7 +201,11 @@ Also see examples from live epgsql integration tests

### MySQL and [mysql-otp/mysql-otp](https://github.com/mysql-otp/mysql-otp)
#### Onboarding comments
+
+ almost no result-set parsing required
- [implicit commit](https://dev.mysql.com/doc/refman/5.7/en/implicit-commit.html)
specifics a kind an obstacle for simple and safe migration
- mysql docker tooling should be operated carefully and ensured for
proper startup before any use
#### Code sample
<details>
<summary>Click to expand</summary>
Expand All @@ -214,7 +218,7 @@ Also see examples from live epgsql integration tests
fun(F) ->
%% no full-scope tx API available here
%% or use mysql:transaction/2, but please be aware about
%% mysql implicit transactions behavior
%% mysql implicit transactions commit behavior
try F() of
Res -> Res
catch
Expand Down

0 comments on commit 891264a

Please sign in to comment.