Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP 7.3 and 7.4 and optimized for PHP 8 #34

Merged
merged 15 commits into from
Jan 6, 2023

Conversation

NaokiTsuchiya
Copy link
Contributor

@NaokiTsuchiya NaokiTsuchiya commented Jan 5, 2023

合わせて getResourceListGenerator および ResMetaclassResourceObjectclass でのみ構成されるように変更

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c0300b5) compared to base (77c12b9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##                 1.x       #34   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        17        19    +2     
===========================================
  Files              3         3           
  Lines             39        40    +1     
===========================================
+ Hits              39        40    +1     
Impacted Files Coverage Δ
src/AbstractAppMeta.php 100.00% <100.00%> (ø)
src/ResMeta.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koriym
Copy link
Member

koriym commented Jan 5, 2023

https://github.com/bearsunday/BEAR.AppMeta/blob/1.x/vendor-bin/tools/composer.json#L3

csのバージョンもあげましょうか?

@NaokiTsuchiya
Copy link
Contributor Author

コーディングスタンダード含むSAツールのバージョンも更新しました。

psalm は v5 にアップグレードされています。

https://psalm.dev/articles/psalm-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants