Fix PHP 8.1 deprecation warnings with unserializable symfony cache component support #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
koriym
commented
Nov 5, 2021
•
koriym
commented
- Fix PHP 8.1 deprecation warnings in Serializable interface
- Instantiate symfony cache component which is unserializable in __unserialize with injected Injector.
koriym
force-pushed
the
php8.1-serializable
branch
from
4aa22ad
to
2b73ca7
Compare
Codecov Report
@@ Coverage Diff @@
## 1.x #100 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 225 228 +3
===========================================
Files 48 49 +1
Lines 671 692 +21
===========================================
+ Hits 671 692 +21
Continue to review full report at Codecov.
|
koriym
force-pushed
the
php8.1-serializable
branch
3 times, most recently
from
b47c888
to
441972e
Compare
reduce cognitive load
koriym
force-pushed
the
php8.1-serializable
branch
from
441972e
to
22b6678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.