Regarding Python ≥ 3.9 requirement for validators #34

rsokl · 2021-05-26T13:32:57Z

Heya @leycec, I am excited to be messing around with beartype's new validators! A question about the Python ≥ 3.9 requirement: is there a reason why typing_extensions.Annotated cannot be used to enable use of validators with earlier versions of Python?

I tried rerunning the polygon_area example in your readme using typing_extensions.Annotated, but ended up eating dirt at the feet of BeartypeDecorHintNonPepException.

Congratulations on 0.7.0!

P.S. in the polygon_area, ndarray should be np.ndarray so that readers don't hit an import error.

The text was updated successfully, but these errors were encountered:

leycec · 2021-05-27T03:20:31Z

...is there a reason why typing_extensions.Annotated cannot be used to enable use of validators with earlier versions of Python?

</double_facepalm>

I... somehow didn't think of the most obvious thing. Beartype definitely should support the full typing_extensions package, but currently doesn't do to asinine assumptions I made a year ago in the private beartype._util.hint.pep.utilhintpepget.get_hint_pep_sign() function we internally use to classify incoming type hints. Just "Blurgh!"

I consider this a critical issue – especially with validators now locked behind a Python version most users won't even be able to readily use for another year or two. Let's see what Uncle Leycec can do for everyone to patch in mostly worky typing_extensions support this week.

Thanks for the steady stream of bright ideas, Ryan! You shine a light on the dark spaces in our codebase, which is most of them. 🕯️ 🕯️ 🕯️

P.S. in the polygon_area, ndarray should be np.ndarray so that readers don't hit an import error.

@rsokl the MVP (Most Valuable Pythonista) right here. Let's fix that before I embarrass myself any further. 😓

@rsokl

This commit is the first in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit both implements and tests the new private `beartype._util.py.utilpymodule.is_module()` tester required to efficiently and safely detect optional third-party dependencies like `typing_extensions` as well as resolving a trivial documentation code-string error kindly noted by machine learning guru and all-around stand-up paragon of GitHub virtue @rsokl. (*Felonious melons!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit generalizes the existing `beartype._util.hint.pep.utilhintpepget.get_hint_pep_sign()` getter to transparently support both the `typing` and `typing_extensions` modules. (*Distributional ebullience!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit defines a new private `beartype._util.hint.data.pep.utilhintdatapep` submodule declaring globally usable signs agnostic of any Python version or module and thus transparently supporting both the `typing` and `typing_extensions` modules. (*Rancid ancillaries distil acidic artilleries!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit internally restructures the private `beartype._util.hint.data` subpackage for improved usability, readability, and maintainability (URM). (*Stodgy budgies!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit documents further internal restructing required to resolve this issue in the private `beartype._util.hint.data.datapep` submodule. To avoid "breaking the build," all further commits in this commit chain will be isolated to a new `fix-34` branch. (*Irascible rascals!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit refactors the codebase to identify user-defined generic type hints via the internal `beartype._util.hint.data.pep.sign.datapepsigns.HintSignGeneric` singleton rather than the external `typing.Generic` singleton as well as resolving a subtle outstanding issue with generics under Python 3.6. (*Evidential residence in identical residuals!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit refactors the codebase to dramatically simplify handling of the `typing.NoReturn` singleton. (*Allegro allegations pull aggro!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit refactors the codebase to identify user-defined "new type" hints via the internal `beartype._util.hint.data.pep.sign.datapepsigns.HintSignNewType` singleton rather than the external `typing.NewType` factory function. (*Disruptive eruption!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit refactors the codebase to identify type variables via the internal `beartype._util.hint.data.pep.sign.datapepsigns.HintSignTypeVar` singleton rather than the external `typing.TypeVar` class. (*Padded adders!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit refactors the codebase to identify forward references via the internal `beartype._util.hint.data.pep.sign.datapepsigns.HintSignForwardRef` singleton rather than the external `typing.ForwardRef` class as well as dramatically simplifying the definition of sign sets with a new `beartype._util.hint.data.pep.sign.datapepsignset` submodule. (*Thaumaturgic urges!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit declares a new private `beartype._util.data.hint.pep.sign.datapepsignmap.HINT_BARE_NAME_TO_SIGN` dictionary global mapping from unsubscripting `typing` and `typing_extensions` attribute names to their identifying signs. Notably, this is the last commit of this branch expected to pass tests! *We are now breaking everything, folks.* (*Counterfeit featherweights!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit sanitizes identification of unsubscripted type hints by both defining and calling a new private `beartype._util.hint.pep.utilhintpeptest.is_hint_pep_subscripted()` tester function. Previously, the codebase made unsafe and frankly shameful assumptions about the incestuous relationship between hints and their identifying signs. (*Incorrigible oncology!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit concludes all prerequisites needed to fully implement this refactoring while still passing tests. All subsequent commits, which are the bulk of them, will temporarily break tests as an unavoidable side effect of the severity of this refactoring. (*Clueless clavicles!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit refactors the codebase to identify tuple type hints via the internal `beartype._util.hint.data.pep.sign.datapepsigns.HintSignTuple` singleton rather than the external `tuple` class and `typing.Tuple` singleton. This is likely to break under Python 3.6, but we currently ignore that because *NOBODY* cares about Python 3.6. *NOBODY*! Okay, somebody does. Sorry, somebody. (*Fallacious traces!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit disastrously breaks literally everything by finally committing to this refactoring by disemboweling the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Since everything is now broken, we can only devoutly pray for a miraculously swift and just refactoring. (*Untimely turntables!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Counterweight wights!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Imponderable ponderosa!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Crabby crabapples!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Stubby tubers!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit refactors the codebase to identify tuple type hints via the internal `beartype._util.hint.data.pep.sign.datapepsigns.HintSignTuple` singleton rather than the external `tuple` class and `typing.Tuple` singleton. This is likely to break under Python 3.6, but we currently ignore that because *NOBODY* cares about Python 3.6. *NOBODY*! Okay, somebody does. Sorry, somebody. (*Fallacious traces!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit disastrously breaks literally everything by finally committing to this refactoring by disemboweling the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Since everything is now broken, we can only devoutly pray for a miraculously swift and just refactoring. (*Untimely turntables!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Counterweight wights!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Imponderable ponderosa!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Crabby crabapples!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Stubby tubers!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Stalky chalk!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Inundated exudate!*)

This commit is the next in a commit chain adding transparent support for the third-party `typing_extensions.Annotated` type hint back-ported to Python < 3.9, en route to resolving #34. Once finalized, this will enable usage of beartype validators under Python < 3.9 via this hint. Specifically, this commit continues disastrously breaking literally everything by continuing to disembowel the feckless `beartype._util.hint.data.pep.datapep` submodule and its untrustworthy `beartype._util.hint.data.pep.proposal` crony subpackage in favour of `beartype._util.hint.data.pep.sign`, which is the only subpackage left standing. Save us from our reckless selves, GitHub! (*Provisional revisionism!*)