Don't hide CachingProtocolMeta
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antonagestam, apologies in advance if I stole your thunder, but please consider this only a proposal. It should allow either of the following to work without error: from numerary.protocol import CachingProtocolMeta
from numerary.types import CachingProtocolMetaAs an aside, I'm curious which static type checker you're using. If you have something different in mind, I'm happy to abandon this and consider any alternative. No rush, though. Enjoy your time away from your keyboard! |
posita
force-pushed
the
posita/0/dont-hide-metaclass-15
branch
2 times, most recently
from
7f91c61
to
34601cf
Compare
posita
force-pushed
the
posita/0/dont-hide-metaclass-15
branch
from
34601cf
to
9707621
Compare
|
@antonagestam, if you're cool with it, I'll go ahead and merge this and cut a new release. |
posita
force-pushed
the
posita/0/dont-hide-metaclass-15
branch
from
9707621
to
7b0d0bb
Compare
|
@posita Sounds good :) |
flaeppe
added a commit
to flaeppe/phantom-types
that referenced
this pull request
Nov 16, 2022
flaeppe
added a commit
to flaeppe/phantom-types
that referenced
this pull request
Nov 16, 2022
antonagestam
pushed a commit
to antonagestam/phantom-types
that referenced
this pull request
Nov 16, 2022
This allows removing the ignored typing error on the import of `CachingProtocolMeta`. Refs: - beartype/numerary#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15.