Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Lookuperror traceback noise #113

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Reduce Lookuperror traceback noise #113

merged 3 commits into from
Oct 1, 2023

Conversation

PhilipVinc
Copy link
Collaborator

@PhilipVinc PhilipVinc commented Sep 30, 2023

This is an easy one.

Essentially discard all traceback informations from previous raises that just pollute the error

see this PR vs master (you can see that in master there are several errors in the stack, while in this PR only one)

Screenshot 2023-10-01 at 00 55 01

@coveralls
Copy link

coveralls commented Sep 30, 2023

Pull Request Test Coverage Report for Build 6366230310

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6364580476: 0.0%
Covered Lines: 938
Relevant Lines: 938

💛 - Coveralls

@wesselb
Copy link
Member

wesselb commented Oct 1, 2023

This is great! Thanks!! Wasn’t even aware of this syntax. :)

@wesselb wesselb merged commit fddf2da into master Oct 1, 2023
11 of 12 checks passed
@PhilipVinc PhilipVinc deleted the pv/errors branch October 1, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants