Add type hints to the convert methods #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
nstarman
force-pushed
the
typing-conversion
branch
from
90e191c
to
3a11342
Compare
wesselb
reviewed
May 12, 2024
plum/promotion.py
Outdated
| @@ -57,11 +70,13 @@ def add_conversion_method(type_from, type_to, f): | |||
| """ | |||
|
|
|||
| @_convert.dispatch | |||
| def perform_conversion(obj: type_from, _: type_to): | |||
| def perform_conversion(obj, _): | |||
There was a problem hiding this comment.
The tests might be failing because the type annotations here are not there anymore.
Pull Request Test Coverage Report for Build 9053144554Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
This looks great!! Thanks :). Merging right away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.