Fixed correct operation when input is negative #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two integers -1 and 255 represent the same byte (0xFF), but the code would handle -1 incorrectly because input numbers weren't properly masked so negative integers would case the combining step in encodeChunk to produce the wrong triplet. As an example, the triplet [0, -73, 23] - [0x00, 0xB7, 0x17]) would combine into the integer -18665 (0xFFFFB717) instead of the expected 46871 (0x0000B717). This is fixed by correctly masking input values before combining them into an integer.
Raniz85
force-pushed
the
negative-numbers
branch
from
914ea13
to
57ed019
Compare
|
Sorry for the delay. I just confirmed your fix, merged, and released as 1.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two integers -1 and 255 represent the same byte (0xFF),
but the code would handle -1 incorrectly because input numbers
weren't properly masked so negative integers would case the
combining step in encodeChunk to produce the wrong triplet.
As an example, the triplet [0, -73, 23] - [0x00, 0xB7, 0x17])
would combine into the integer -18665 (0xFFFFB717) instead of
the expected 46871 (0x0000B717).
This is fixed by correctly masking input values before combining
them into an integer.
This fixes #38