Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MarshalJSON to sync types #121

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Add MarshalJSON to sync types #121

merged 1 commit into from
Jul 7, 2022

Conversation

GerardRodes
Copy link
Contributor

@GerardRodes GerardRodes commented Jun 3, 2022 •
edited

Which problem is this PR solving?

Issue with explanation

Short description of the changes

Implementation of JSON Marshaller interfaces

@GerardRodes GerardRodes force-pushed the master branch 2 times, most recently from d546090 to b4a061f Compare July 4, 2022 14:13
@GerardRodes GerardRodes marked this pull request as ready for review July 4, 2022 14:13
mantzas
mantzas requested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@mantzas mantzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also like to add tests for all of these cases?

sync/sync.go Outdated Show resolved Hide resolved
@GerardRodes GerardRodes requested a review from mantzas July 5, 2022 11:28
@mantzas mantzas merged commit d1bb448 into beatlabs:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantzas mantzas mantzas approved these changes

@c0nstantx c0nstantx Awaiting requested review from c0nstantx

@Lazaros-Tsigkakos Lazaros-Tsigkakos Awaiting requested review from Lazaros-Tsigkakos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GerardRodes @mantzas