Add StringSlice type to sync #136
Conversation
| for _, item := range strings.Split(val, ",") { | ||
| slice = append(slice, strings.TrimSpace(item)) | ||
| } | ||
| s.Set(slice) |
There was a problem hiding this comment.
Q: Do we want to trim spaces?
I'm not aware of any use cases, just thinking about it since trimming trailing and leading spaces seems more strict than not trimming them
There was a problem hiding this comment.
The reason is that this will often be used for configuration, and a leading/trailing space can be hard to spot when something is failing.
The original stringMap was first code in API Gateway, and we actually had an issue during deployment because of a space, which is why this code has trims :)
There was a problem hiding this comment.
Makes sense 👍 .
I guess we can assume that in most cases we don't need leading and trailing spaces.
And as discussed, if we need more advanced options, such as supporting leading/trailing spaces and , we could introduce a more powerful mechanism (such as quotes and escaping).
Implements a simple version of issue #66