Introduce SpanComplete instead SpanError&SpanSuccess #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardaguclu
requested review from
cpapidas,
drakos74,
fpapadopou,
mantzas,
moukoublen and
sotirispl
as code owners
mantzas
requested changes
Jan 11, 2020
mantzas
requested changes
Jan 11, 2020
mantzas
requested changes
Jan 12, 2020
There was a problem hiding this comment.
Hi, like mentioned before defer is usually used to cleanup resources(file close) or handle panics with recover.
I have added two suggestions which makes the code much simple should be fixed.
The same pattern applies to all the rest of the code and should be applied ther as well.
drakos74
approved these changes
Jan 15, 2020
mantzas
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #123
Short description of the changes
As mentioned in the issue referenced, SpanSuccess and SpanError are used seperately. Instead using these, introducing SpanComplete makes code simpler. This PR is the change of this refactoring.