Add ActiveBrokers() method to Kafka AsyncProducer #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sotirios Mantziaris <smantziaris@gmail.com>
Signed-off-by: Sotirios Mantziaris <smantziaris@gmail.com>
Signed-off-by: Sotirios Mantziaris <smantziaris@gmail.com>
Signed-off-by: Sotirios Mantziaris <smantziaris@gmail.com>
Signed-off-by: Sotirios Mantziaris <smantziaris@gmail.com>
gm42
requested review from
cpapidas,
drakos74,
fpapadopou,
mantzas,
moukoublen and
sotirispl
as code owners
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 84.40% 84.38% -0.02%
==========================================
Files 51 52 +1
Lines 3046 3068 +22
==========================================
+ Hits 2571 2589 +18
- Misses 397 399 +2
- Partials 78 80 +2
Continue to review full report at Codecov.
|
mantzas
previously approved these changes
Mar 22, 2020
|
@gm42 you have breaking changes due to a refactoring of packages. All client code has now been moved to the client package. |
drakos74
previously approved these changes
Mar 24, 2020
drakos74
reviewed
Mar 25, 2020
| func (ap *AsyncProducer) ActiveBrokers() []string { | ||
| brokers := ap.prodClient.Brokers() | ||
| activeBrokerAddresses := make([]string, len(brokers)) | ||
| for i, b := range brokers { |
There was a problem hiding this comment.
Would you consider using „copy“ for a slice ? And let go do the memory re-arrangement under the hood ?
There was a problem hiding this comment.
@drakos74 can you make an example for this specific loop? I don't think copy can be used here.
|
Closed in favor of #192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
ActiveBrokers()method to KafkaAsyncProducer. It also expands the GoDoc comment for Close() method and fixes a typo in an error message.Which problem is this PR solving?
Fixes #169