Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil consumer group #208

Merged
merged 1 commit into from May 13, 2020
Merged

Fix nil consumer group #208

merged 1 commit into from May 13, 2020

Conversation

kasperbe
Copy link

@kasperbe kasperbe commented May 13, 2020

Closes #209

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #208 into master will decrease coverage by 0.13%.
The diff coverage is 84.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   84.48%   84.35%   -0.14%     
==========================================
  Files          52       52              
  Lines        3074     3093      +19     
==========================================
+ Hits         2597     2609      +12     
- Misses        398      402       +4     
- Partials       79       82       +3     
Impacted Files Coverage Δ
client/amqp/amqp.go 40.98% <ø> (ø)
client/amqp/option.go 66.66% <ø> (ø)
client/amqp/user.pb.go 26.92% <ø> (ø)
client/http/option.go 100.00% <ø> (ø)
client/redis/redis.go 44.44% <ø> (ø)
client/sns/message.go 97.53% <ø> (ø)
client/sns/publisher.go 93.33% <ø> (ø)
client/sql/sql.go 86.25% <ø> (ø)
client/sqs/message.go 92.50% <ø> (ø)
client/sqs/publisher.go 93.33% <ø> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59b49c...70588b2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when setting up consumer group without kafka connection
3 participants