Issue #204 - Redis Get response in case of missing value

[christgf]

Signed-off-by: George Christou christgf@gmail.com

Which problem is this PR solving?

Resolves #204 - Redis Get response in case of missing value

Short description of the changes

When returning results from Redis, an empty cache key is handled as an error, which is inconsistent with the caching API interface. The change ensures cache misses don't result in errors, as proposed.
Please note there's currently no test fixture for the Redis cache implementation.

[mantzas]

Nice, thanks very much for the contribution.

[codecov]

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   73.01%   73.01%           
=======================================
  Files          57       57           
  Lines        3332     3332           
=======================================
  Hits         2433     2433           
  Misses        837      837           
  Partials       62       62           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e67018...db834f3. Read the comment docs.

[tpaschalis]

Thank you for taking the time to open your first PR in Patron!

It looks good, just one remark; I think that we can remove this const Nil = redis.Nil as well.

It was used to export the redis.Nil error so that the end-user could implement the cache miss check herself, but this is no longer necessary!

[christgf]

Thank you for taking the time to open your first PR in Patron!

It looks good, just one remark; I think that we can remove this const Nil = redis.Nil as well.

It was used to export the redis.Nil error so that the end-user could implement the cache miss check herself, but this is no longer necessary!

Actually @tpaschalis, it seems that this still serves its original purpose, and removing it would require we import redis/v7 in the Redis cache implementation (which is where the redis.Nil check is needed).
I may be missing your point altogether?

[tpaschalis]

Actually @tpaschalis, it seems that this still serves its original purpose, and removing it would require we import redis/v7 in the Redis cache implementation (which is where the redis.Nil check is needed).
I may be missing your point altogether?

On the other hand, you're right, let's keep the imports tidied up!

[tpaschalis]

LGTM!

[drakos74]

nice!!!