Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude priv directory from Hex package #121

Conversation

milmazz
Copy link
Contributor

@milmazz milmazz commented Dec 1, 2022

The current hex package includes a priv directory with only PLTs needed for dialyzer. These files are not required for the library to work correctly.

I noticed this while I was inspecting the diff between 3.0.3 and 3.0.4 via: https://diff.hex.pm/diff/csv/3.0.3..3.0.4

The current `hex` package includes a `priv` directory with only PLTs needed for `dialyzer`.

I noticed this while I was inspecting the diff between 3.0.3 and 3.0.4 via: https://diff.hex.pm/diff/csv/3.0.3..3.0.4
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 57b45cf on milmazz:milmazz-remove-priv-dir-from-hex-package into 75103e2 on beatrichartz:main.

@beatrichartz
Copy link
Owner

Oh great catch! Thanks!

@beatrichartz beatrichartz merged commit 92d47e8 into beatrichartz:main Dec 1, 2022
@beatrichartz
Copy link
Owner

Released in 3.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants