Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat code #1

Closed
3 tasks done
beatussum opened this issue Aug 13, 2023 · 0 comments
Closed
3 tasks done

Reformat code #1

beatussum opened this issue Aug 13, 2023 · 0 comments
Assignees
@beatussum
Labels
new feature This issue refers to a feature that does not yet exist.
Milestone
Version 1.0

Comments

@beatussum
Copy link
Owner

beatussum commented Aug 13, 2023 •
edited
Loading

Before releasing the version 1.0, PMSExp has to contains the following changes:

  • Update coding style. Indeed, Qt classes and structs use Camel case and currently PMSExp prefers to use Snake case. Therefore, both conventions are present in the current code which should be avoided.
  • Rename gui::widgets::pages to gui::pages.
  • Restructure gui::widgets::ButtonSelecterWidget, gui::widgets::ListSelecterWidget and gui::widgets::SelecterWidget.
@beatussum beatussum added the new feature This issue refers to a feature that does not yet exist. label Aug 13, 2023
@beatussum beatussum added this to the Version 1.0 milestone Aug 13, 2023
@beatussum beatussum self-assigned this Aug 13, 2023
beatussum added a commit that referenced this issue Aug 13, 2023
@beatussum
rename gui::widgets::pages to gui::pages
746386e 
See-also: #1
Signed-off-by: Mattéo Rossillol‑‑Laruelle <beatussum@protonmail.com>
beatussum added a commit that referenced this issue Aug 13, 2023
@beatussum
update coding style
99de2da 
Methods of Qt classes now use the Qt coding style.

See-also: #1
Signed-off-by: Mattéo Rossillol‑‑Laruelle <beatussum@protonmail.com>
beatussum added a commit that referenced this issue Aug 14, 2023
@beatussum
gui::widgets::*SelecterWidget: revert previous API changes
45a07a1 
Now, the base class `gui::widgets::SelecterWidget` does not manage creation of
the `gui::widgets::StackedWidget` object anymore. Instead, it borrows the
resource in order to handle some slot and signal connections.

See-also: 9f42b7b
See-also: #1
Signed-off-by: Mattéo Rossillol‑‑Laruelle <beatussum@protonmail.com>
beatussum added a commit that referenced this issue Aug 14, 2023
@beatussum
gui::widgets::ProgressButtonSelecterWidget: add class
b7f27dd 
"Progress management" of `gui::widgets::ButtonSelecterWidget` is now provided
by a derived class called `gui::widgets::ProgressButtonSelecterWidget`.

See-also: #1
Signed-off-by: Mattéo Rossillol‑‑Laruelle <beatussum@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beatussum beatussum

Labels
new feature This issue refers to a feature that does not yet exist.
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
1 participant
@beatussum