Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Uncaught ReferenceError: module is not defined #15

Closed
mklocek opened this issue Nov 20, 2015 · 1 comment
Closed

Error: Uncaught ReferenceError: module is not defined #15

mklocek opened this issue Nov 20, 2015 · 1 comment

Comments

@mklocek
Copy link
Contributor

mklocek commented Nov 20, 2015

Exporting module:

module.exports = {
  JsonApiDataStore: JsonApiDataStore,
  JsonApiDataStoreModel: JsonApiDataStoreModel
};

Not works in non-nodejs and non-browserify environments. There is no need to always use requirejs and stuff like that. I'm suggesting add module existance check. I'm ready to create PR if you agree.

@beauby
Copy link
Owner

beauby commented Nov 20, 2015

Agreed. It was the case pre-es6 translation. Would love a PR.

Le vendredi 20 novembre 2015, Marcin Klocek notifications@github.com a
écrit :

Exporting module:

module.exports = {
JsonApiDataStore: JsonApiDataStore,
JsonApiDataStoreModel: JsonApiDataStoreModel
};

Not works in non-nodejs and non-browserify environments. There is no need
to always use requirejs and stuff like that. I'm suggesting add module
existance check. I'm ready to create PR if you agree.


Reply to this email directly or view it on GitHub
#15.

Lucas Hosseini
lucas.hosseini@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants