Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion to reverse format and back for ipv4 #140

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

leftshift
Copy link
Contributor

I noticed there already are functions to convert to and from the reverse form for v6 addresses. I also need this functionality for v4 addresses, so this adds the same kind of functions to the v4 addresses.

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #140 (15215b8) into master (94b367c) will decrease coverage by 0.48%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   98.04%   97.56%   -0.49%     
==========================================
  Files           9        9              
  Lines         564      575      +11     
  Branches       82       84       +2     
==========================================
+ Hits          553      561       +8     
- Misses          3        4       +1     
- Partials        8       10       +2     
Impacted Files Coverage Δ
lib/common.ts 100.00% <ø> (ø)
lib/ipv4.ts 97.00% <72.72%> (-3.00%) ⬇️
lib/ipv6.ts 98.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b367c...15215b8. Read the comment docs.

@beaugunderson
Copy link
Owner

@leftshift love it, thanks! will cut a release shortly after I merge 👍

@beaugunderson beaugunderson merged commit 047b4a0 into beaugunderson:master Jul 19, 2021
@beaugunderson
Copy link
Owner

released in 8.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants