Tagged Template literals

[laggingreflex]

Description

Are there any rules that apply to Tagged Template literals?

Specifically:

• Case 1:

  Input

  fn`tagged`
  

  Expected: no change

  fn`tagged`
  

  Actual: space inserted

  fn `tagged`
    ^ space inserted
  

• Case 2:

  Input

  fn()`tagged`
  

  Expected: no change

  fn()`tagged`
  

  Actual: newline inserted

  fn()
  `tagged`
  ^ newline inserted
  

[bitwiseman]

Not currently supported. Didn't even know this existed. Thanks!

[JuanFML]

Hello everyone, I am new here, is there a chance I can try this as my first issue?

[bitwiseman]

@JuanFML
You are welcome to give it a try, but it may be a little tricky. You'll probably want to make the change in this method:

https://github.com/beautify-web/js-beautify/blob/97caa308491e1379b226c514f677fa4f278e15d4/js/src/javascript/beautifier.js#L1059-L1077

If the STRING token that is about to be processed is a backtick string and is preceded by a literal with no space in between, then do not add a space or newline.

[JuanFML]

Ok! I will be trying it out, thank you! If I get stuck I will let you know

[JuanFML]

Hi @bitwiseman, I've been working on this, but I would like to know if I am doing it right, so far I figure out a condition and added it in the method you mentioned, I opend a PR as the test passed with make jstest, but when I run make I am having troubles to solve the other implementations.

[JuanFML]

I am now working in this part to fix the issue with the implementations https://github.com/beautify-web/js-beautify/blob/97caa308491e1379b226c514f677fa4f278e15d4/python/jsbeautifier/javascript/beautifier.py#L1186-L1212

[JuanFML]

I have solved the remaining tests and fixed errors that appeared on my PR in Azure DevOps, please let me know if the changes are ok