Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate unpackers into beautify functionality #224

Open
bitwiseman opened this issue Apr 4, 2013 · 2 comments
Open

Integrate unpackers into beautify functionality #224

bitwiseman opened this issue Apr 4, 2013 · 2 comments
Labels
language: javascript type: enhancement

Comments

@bitwiseman
Copy link
Member

Currently, the unpackers are separate from beautify.js and only exposed via the web page. They should be a feature of the beautifier functionality, so that users passing a packed script to node or the web page get the same result.
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Apr 4, 2013
@bitwiseman
Reorganize file structure by language/platform
5a89a3e 
Moved all files that are specifically for the website into web (except for index.htm)
Moved all files that are javascript (for node or web) into js
Organized js folder to generally follow node structures

This change also changes .npmignore to include unpackers in the package.
First step on beautifier#224.
@bitwiseman bitwiseman mentioned this issue Apr 4, 2013
Merged
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Apr 4, 2013
@bitwiseman
Reorganize file structure by language/platform
5af9536 
Moved all files that are specifically for the website into web (except for index.htm)
Moved all files that are javascript (for node or web) into js
Organized js folder to generally follow node structures

This change also changes .npmignore to include unpackers in the package.
First step on beautifier#224.
@evocateur
Copy link
Contributor

This would presumably need a CLI option to employ it, because inferring the format from the content seems incredibly brittle. --unpacker <foo>, or the like.

@bitwiseman
Copy link
Member Author

Brittle: but that is exactly what the unpackers do right now. 😄

Agreed a cli option, at least to specify which unpackers to consider, or which specific unpacker to use would be needed. We don't want to tax scenarios that don't need the unpacking features.

bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Apr 4, 2013
@bitwiseman
Reorganize file structure by language/platform
f28d132 
Moved all files that are specifically for the website into web (except for index.htm)
Moved all files that are javascript (for node or web) into js
Organized js folder to generally follow node structures

This change also changes .npmignore to include unpackers in the package.
First step on beautifier#224.
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Apr 4, 2013
@bitwiseman
Reorganize file structure by language/platform
9de057f 
Moved all files that are specifically for the website into web (except for index.htm)
Moved all files that are javascript (for node or web) into js
Organized js folder to generally follow node structures

This change also changes .npmignore to include unpackers in the package.
First step on beautifier#224.
@bitwiseman bitwiseman mentioned this issue Jan 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language: javascript type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evocateur @bitwiseman