yield statements are being beautified to their own newlines since 1.5.2

[jemartti]

Version @1.5.2 included 820d267 to resolve #458. However, this fix introduced some unintended behaviour for beautifying code that includes yield statements; specifically, it's forcing every yield statement to start on a new line.

For example:

result = yield pgClient.query_(queryString);

is being beautified to:

result = 
    yield pgClient.query_(queryString);

when it should be remaining unchanged.

Since we're building a koa app, we're stuck with pinning to version @1.5.1 as this is causing some widespread annoyances in our codebase.

[dashed]

+1. Can confirm when using the following Sublime Text 3 plugin: https://github.com/victorporof/Sublime-HTMLPrettify

[haoxins]

+1

[dotcypress]

+1

[valentinkostadinov]

+1

[magicdawn]

+1

@jdc0589 when can this yield fixed in JsFormat

[drewhamlett]

Any news on this?

[bitwiseman]

I've been busy with the job that pays me...

[drewhamlett]

Haha. I got you man. I'll get you a pull request.

[divergant]

I want to see an Extension for Brackets
like this photo
http://oi59.tinypic.com/30tri94.jpg
when I select tag the points between open and closed tag colored with red
also I have closing and opening mark in the left
just like Notepad++

[MetaMemoryT]

👍

[magicdawn]

Any Update ...

I tried to remove yield form line_starters, it just workes for this case. Don't know whether this will bring other side effects.

https://github.com/beautify-web/js-beautify/blob/master/js/lib/beautify.js#L1429

test.js

function test * (arg1) {
  var text = yield getText();
}

should I get PR for this small modification ?

[magicdawn]

手滑 function * test 写成了 function test *

[jemartti]

@magicdawn: #458 explains why yield is placed in line_starters.

We can't keep going back and forth on these two bugs; a proper solution is needed.

[bitwiseman]

@jemartti - we're not going back and forth. That bug got closed and has stayed closed, this is a follow on bug.

yield is a keyword but it could probably just be moved to reserved words.

[jemartti]

@bitwiseman: I know, I'm the one that opened this issue and pointed out that it's a follow–on bug from #458 :). My comment was referring to @magicdawn's suggestion not being sufficient, as it would result in reopening the previous bug.

[bitwiseman]

Ah. 😄 Got it.