Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Individual tests pollute options object #855

Closed
robrez opened this issue Jan 27, 2016 · 1 comment
Closed

Individual tests pollute options object #855

robrez opened this issue Jan 27, 2016 · 1 comment
Labels
type: task
Milestone
v1.6.0

Comments

@robrez
Copy link
Contributor

robrez commented Jan 27, 2016

Currently, individual tests are re-using the same options object. This means an individual test must undo options set by any previous tests (which can be tough to keep track of).

Thoughts on creating a new vanilla options object for each test?
@bitwiseman bitwiseman added this to the v1.6.0 milestone Jan 27, 2016
@bitwiseman
Copy link
Member

Good idea.

bitwiseman added a commit that referenced this issue Jan 27, 2016
@bitwiseman
Reset options added to all test modules
e21e14d 
Fixes #855
@pyup-bot pyup-bot mentioned this issue Mar 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
2 participants
@bitwiseman @robrez