[ISSUE 1846] Resolve indent issue with class method named in #2004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
main
)Fixes Issue:
#1846 Originally, if a class method was named
in
, it would get reformatted one level too far. This was caused by a previous hack for thein
andof
keywords, which would be tokenized asOPERATOR
s.The fix was to tokenize
in
andof
asOPERATOR
s only if the previous token was aWORD
orSTRING
. This was how I differentiated betweenin
/of
as a keyword or as a class method name. Note: these changes resolve the issue for theof
keyword as well.I added unit tests to test
in
/of
in cases in which they are keywords and when they are class method names.CURRENT DISCUSSION:
/test/data/*/test.js
, corresponding tests are automatically generated for the Python implementation. Is this correct?.js
file myself, ran./tools/python-dev js-beautify
on my file, and found that the issue was actually reproducible in the Python implementation.Before Merge Checklist
These items can be completed after PR is created.
(Check any items that are not applicable (NA) for this PR)