Added max width to the column with editor area. I used 'minmax' grid … #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function for this.
ShetlandJ
approved these changes
Jun 27, 2022
mhnaeem
reviewed
Jun 29, 2022
web/common-style.css
Outdated
| @@ -74,7 +74,7 @@ input[type="checkbox"], select, button { | |||
|
|
|||
| .container { | |||
| display: grid; | |||
| grid-template-columns: 1.6fr 0.9fr; | |||
| grid-template-columns: minmax(auto, 1209px) 0.9fr; | |||
There was a problem hiding this comment.
@SimaDovakin I was the person responsible for this change 😅, thanks for fixing it!
I do have a suggestion though, have you tried setting something like grid-template-columns: calc(100vw/1.6) calc(100vw/0.9); instead? It might be more responsive to the different screen sizes and probably a longer term fix.
There was a problem hiding this comment.
Thank you for review. I'll fix it in this way.
There was a problem hiding this comment.
I added new commit.
mhnaeem
approved these changes
Jun 30, 2022
bitwiseman
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…function for this.
Description
main)Fixes Issue:
Fix #2071
Before Merge Checklist
These items can be completed after PR is created.
(Check any items that are not applicable (NA) for this PR)