Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new record types #2099

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

cwthedev
Copy link
Contributor

@cwthedev cwthedev commented Sep 9, 2022

Fixes #2062

Description

  • Source branch in your fork has meaningful name (not main)

Fixes Issue:

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • [NA] Added command-line option(s) (NA if
  • [ NA] README.md documents new feature/option(s)

@bitwiseman bitwiseman changed the title changes to both js and python jsbeautifiers for issue #2062 to accout… Add support for new record types Oct 1, 2022
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup and Needs more tests. This verifies formatting of the #{ but not much else. Where are these record types used? What does a more involved record look like and does it also behave as expected.

@@ -1,5 +1,5 @@
# Description
- [ ] Source branch in your fork has meaningful name (not `main`)
- [ Iss2062_records ] Source branch in your fork has meaningful name (not `main`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert all changes to this file. This is the template for all PRs.

@bitwiseman bitwiseman merged commit ada9f66 into beautifier:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erroneous output with upcoming Records syntax
2 participants