Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #453, Incompatible handlebar syntax #468

Merged
merged 3 commits into from May 21, 2014
Merged

fix for #453, Incompatible handlebar syntax #468

merged 3 commits into from May 21, 2014

Conversation

soenkeschnoor
Copy link
Contributor

As suggested by yourself in #453, this should ignore the contents of this script/style tags.

Hope it helps. :)

@bitwiseman
Copy link
Member

Looks very nice. Minimal changes, for maximal effect. Can you wrap your lines to not be super long and maybe modify or remove the comments currently at the end of those long lines?

@soenkeschnoor
Copy link
Contributor Author

Sure. No problem.

bitwiseman added a commit that referenced this pull request May 21, 2014
Ignore html script and style tags with unexpdcted type attributes
Fixes #453
@bitwiseman bitwiseman merged commit 9d0ecf8 into beautifier:master May 21, 2014
@bitwiseman bitwiseman added this to the v1.5.2 milestone May 21, 2014
@Infocatcher
Copy link
Contributor

Also should be supported text/ecmascript, application/javascript, and application/ecmascript:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-type
With version, like application/javascript;version=1.8 (just a note, currently works fine with text/javascript;version...):
https://developer.mozilla.org/en-US/docs/Web/JavaScript/New_in_JavaScript/1.8
And legacy things like application/x-javascript:
https://www.google.com/search?q=%22application%2Fx-javascript%22%20-%22/search?q=%22%20site:developer.mozilla.org/en-US/

@bitwiseman
Copy link
Member

Cool, please file a separate bug and we'll get back to it. This PR is done.

@Infocatcher
Copy link
Contributor

I've created another PR instead: #471

@soenkeschnoor soenkeschnoor deleted the incompatible-handlebar-syntax branch May 24, 2014 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants