CSS: support add newline between rules #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, this is my first time using CI and mustache, so I tried many times to pass it. |
| } | ||
| ], | ||
| tests: [ | ||
| { input: '.div {}\n.span {}', output: '.div {}{{separator}}.span {}'} |
There was a problem hiding this comment.
This is a great start, but a few more tests are needed.
|
More tests and please squash your commits down to one. |
|
I add more tests and squash them, if I have to do other things please let me know, thanks! |
| @@ -0,0 +1,87 @@ | |||
| 0 info it worked if it ends with ok | |||
|
Ok, I'll add more tests, thanks. |
It's suggested by [Google](https://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml#CSS_Formatting_Rules) that newline should be added between rules, so I think we should support that and try to make it. I added this behavior to both JS and Python with tests. Besides, I added the new option to README and cli.js. If I need to modify other files, please let me know. Thanks! complete cli.js fix bugs in test.py fix tests use newLine function fix python tests fix tests use indentLevel instead of nestedLevel match default js tests still Revert "still" This reverts commit 32797e8. Find it! update tests file add more tests add test fix test fix test fix test fix test fix test fix test fix test
|
I hava added more tests, should I do something else? |
|
Sorry, I click the close button by mistake... |
|
Thanks for seeing this through. This should sufficiently address #467, I think as well. |
bitwiseman
added a commit
that referenced
this pull request
Dec 8, 2014
CSS: support add newline between rules
|
Great news ! |
|
I hope the Sass support for the next version.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's suggested by Google that newline should be added between rules, so I think we should support
that and try to make it.
I added this behavior to both JS and Python with tests. Besides, I added
the new option to README and cli.js.
If I need to modify other files, please let me know.
Thanks!