Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js package #181

Closed
iki opened this issue Mar 12, 2013 · 15 comments
Closed

Node.js package #181

iki opened this issue Mar 12, 2013 · 15 comments

Comments

@iki
Copy link

iki commented Mar 12, 2013

would be nice.

This one says to be official (ie. links to this project repository), but is not updated https://npmjs.org/package/beautifyjs

There are some clones but do not work well:
https://www.google.com/search?num=100&ncr&q=site:npmjs.org+einars

Thanks for a great tool anyway.

@einars
Copy link
Contributor

einars commented Mar 12, 2013

Node is a dark territory for me and I don't know what would be required for a neat, up-to-date package. Can somebody who actually uses node and would benefit from an updated npm package give a pinch to clarkf — or even overtake the package maintenance, or something?

@RichardBronosky
Copy link
Contributor

I suggest contacting the "maintainer" and ask them to update it from git.
It's probably just a case of a guy who wanted to install it via the package
manager for his project. He just doesn't stay on top of all the
developments.

I created https://pypi.python.org/pypi/jsbeautifier/1.0 after getting
approval. I'm guilty of the same negligence.

On Tue, Mar 12, 2013 at 10:20 AM, Einar Lielmanis
notifications@github.comwrote:

Node is a dark territory for me and I don't know what would be required
for a neat, up-to-date package. Can somebody who actually uses node and
would benefit from an updated npm package give a pinch to clarkf — or even
overtake the package maintenance, or something?


Reply to this email directly or view it on GitHubhttps://github.com//issues/181#issuecomment-14777621
.

.!# RichardBronosky #!.

@RichardBronosky
Copy link
Contributor

I think that the github repo should have tagged releases so that folks
trying to manage packages in places like pypi, npm, debian, etc. can know
what commits represent "you should update now".

It's kind of chaotic to just track master.

On Tue, Mar 12, 2013 at 11:20 AM, Richard Bronosky Richard@bronosky.comwrote:

I suggest contacting the "maintainer" and ask them to update it from git.
It's probably just a case of a guy who wanted to install it via the package
manager for his project. He just doesn't stay on top of all the
developments.

I created https://pypi.python.org/pypi/jsbeautifier/1.0 after getting
approval. I'm guilty of the same negligence.

On Tue, Mar 12, 2013 at 10:20 AM, Einar Lielmanis <
notifications@github.com> wrote:

Node is a dark territory for me and I don't know what would be required
for a neat, up-to-date package. Can somebody who actually uses node and
would benefit from an updated npm package give a pinch to clarkf — or even
overtake the package maintenance, or something?


Reply to this email directly or view it on GitHubhttps://github.com//issues/181#issuecomment-14777621
.

.!# RichardBronosky #!.

.!# RichardBronosky #!.

@iki
Copy link
Author

iki commented Mar 13, 2013

Ok, sounds good. Looked at the package and it is just the lib + package.json. No cmdline interface script. So it would be just best to do the package from scratch and negotiate with Clark to replace it as it holds this project name currently.

We can probably start with another node package, which works, but does not seem to be maintained. https://github.com/rickeyski/node-beautifier/issues

@bitwiseman
Copy link
Member

I've emailed clark. Let's see if he responds within a few days and then go from there.

@RichardBronosky - how hard involved is the maintenance on pypi?

@evocateur
Copy link
Contributor

My fork (the node-package branch) provides js-beautify on npm, with tagged releases and a full-featured command line interface. I'd be happy to have it merged back upstream, and provide assistance doing so.

https://github.com/evocateur/js-beautify

@iki
Copy link
Author

iki commented Mar 15, 2013

@evocateur, it works great, many thanks!

btw, you might want to add the 'Node package' header to README, or link to https://github.com/evocateur/js-beautify#javascript at npm, as the #node-package anchor is currently not working

@bitwiseman
Copy link
Member

Yes, we should merge this up. That'd be great!

@RichardBronosky
Copy link
Contributor

Agreed

Sent from my Samsung Galaxy S3 using the Swype software keyboard.
--Richard Bronosky
On Mar 15, 2013 2:27 AM, "Liam Newman" notifications@github.com wrote:

Yes, we should merge this up. That'd be great!


Reply to this email directly or view it on GitHubhttps://github.com//issues/181#issuecomment-14945641
.

@evocateur
Copy link
Contributor

The #node-package anchor actually is a way to specify the branch used by the npm package. It's not meant to link to a place in the README.

I'll try to get a pull request ready sometime this weekend.

This was referenced Mar 18, 2013
@evocateur
Copy link
Contributor

Here's my pull request: #192

@bitwiseman
Copy link
Member

Awesome!

FYI, I've got an email off to clark and the npm admins about getting the the repo url fixed. It may be a week or so until that gets settled.

@evocateur
Copy link
Contributor

Yeah, I saw that, thanks for the CC. I don't think we need to include Isaac Schlueter, though. We should be able to work it out with the maintainer of the other package.

@bitwiseman
Copy link
Member

And clark responded, so we're in the clear.

@bitwiseman
Copy link
Member

This is done. I've been able to publish a new version of the npm package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants