Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistent_comment_rule option for CSS #679

Closed
wants to merge 1 commit into from

Conversation

leoliudeprecated
Copy link

No description provided.

@leoliudeprecated
Copy link
Author

consistent_comment_rule option is false by default.
This change is not only in javascript, but also in python codes and regressions.
This shall be an option to be used for brackets-beautify project as an extension for Brackets.
https://github.com/leoliu1313/brackets-beautify
https://github.com/drewhamlett/brackets-beautify
http://brackets.io/

@leoliudeprecated
Copy link
Author

Travis CI is clean now.
https://travis-ci.org/beautify-web/js-beautify/builds/60225208
https://travis-ci.org/leoliu1313/js-beautify

Travis CI error is fixed by uploading the output files generated by Makefile.

@bitwiseman
Copy link
Member

Excellent. Yes, checking in the outputs in this case is correct. I'll review this shortly.

@leoliudeprecated
Copy link
Author

Thank you!

@leoliudeprecated
Copy link
Author

This shall fix the folloing issues.
#531
#609
#645

@loganknecht
Copy link

Hi there, I'm interested to know if this has been reviewed and if its integration is planned.

Specifically because I'm looking for a solution to fix the issue I'm encountering with #609.

@bitwiseman
Copy link
Member

Reviewed now. I'm not convinced this is the right path for this. This doesn't so much fix the issues you listed as create a different set of issues. If we're going to make this change it shouldn't be an option, it should be the standard behavior.

Having "consistent" behavior is good, but this implementation produces worse outputs in some cases.

@bitwiseman
Copy link
Member

@loganknecht - #609 fixed. Will be in next release coming within the week.

@bitwiseman bitwiseman closed this Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants