Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'<?php ?>' as a single html tag. #744

Closed
wants to merge 1 commit into from
Closed

'<?php ?>' as a single html tag. #744

wants to merge 1 commit into from

Conversation

yustnip
Copy link

@yustnip yustnip commented Jul 22, 2015

Added '?php' to the list of single tags. It will allow to get a pretty code when HTML contains constructions like .

@bitwiseman
Copy link
Member

Need some added tests before we can merge this.

@Oxicode
Copy link

Oxicode commented Nov 30, 2015

+1

@bitwiseman
Copy link
Member

@Oxicode - Thanks for the vote! it looks like @yustnip is not responding, would you like to add tests that show this working?

@yustnip
Copy link
Author

yustnip commented Nov 30, 2015

I don't know how to do it right. :) I can provide screenshots:
https://yadi.sk/i/PMRg8KFLkrsmg
https://yadi.sk/i/GoaJqyBckrsnD

@bitwiseman
Copy link
Member

Sorry, screenshots don't help at all. Need to have repeatable tests.
Make changes to https://github.com/beautify-web/js-beautify/blob/master/test/data/html.js
Then run make testj. That will generate tests based on the data you added, and then will run them.

@bitwiseman
Copy link
Member

Looks like this would fix #826.

bitwiseman added a commit to bitwiseman/js-beautify that referenced this pull request Jan 21, 2016
@bitwiseman bitwiseman removed this from the v1.6.0 milestone Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants