CSS: Preserve white space before pseudo-class and pseudo-element selectors #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preserved, since "a :b" is not the same as "a:b"
|
I have changed the |
|
Ah, you need to update the python implementation as well. It is really easy. |
…selectors is preserved" in the Python code
| @@ -409,6 +409,10 @@ def beautify(self): | |||
| else: | |||
| # sass/less parent reference don't use a space | |||
| # sass nested pseudo-class don't use a space | |||
|
|
|||
| # preserve space before pseudoclasses/pseudoelements, as it means "in any child" | |||
|
Alignment of the comment in the python code. Then I can merge! |
|
@bitwiseman Ok, done. Python is really tricky with that tabs vs spaces thing. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was raised in a question in Meta Stack Overflow - Stack Overflow uses js-beautify in the code snippets editor.
As explained in the question, the CSS beautifier is converting
tr :first-child {...}intotr:first-child {...}, which is incorrect since both things don't mean the same. This change fixes this.