Skip to content

Commit

Permalink
Merge pull request kubernetes#84888 from neolit123/1.17-fix-kube-prox…
Browse files Browse the repository at this point in the history
…y-env-vars

kubeadm: fix an issue with the kube-proxy container env. variables
  • Loading branch information
k8s-ci-robot committed Nov 7, 2019
2 parents 916776c + 0b4e5ee commit c843d96
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions cmd/kubeadm/app/phases/addons/proxy/proxy.go
Expand Up @@ -129,8 +129,9 @@ func createKubeProxyAddon(configMapBytes, daemonSetbytes []byte, client clientse
if err := kuberuntime.DecodeInto(clientsetscheme.Codecs.UniversalDecoder(), daemonSetbytes, kubeproxyDaemonSet); err != nil {
return errors.Wrap(err, "unable to decode kube-proxy daemonset")
}
// propagate http/https proxy env vars
kubeproxyDaemonSet.Spec.Template.Spec.Containers[0].Env = kubeadmutil.GetProxyEnvVars()
// Propagate the http/https proxy host environment variables to the container
env := &kubeproxyDaemonSet.Spec.Template.Spec.Containers[0].Env
*env = append(*env, kubeadmutil.GetProxyEnvVars()...)

// Create the DaemonSet for kube-proxy or update it in case it already exists
return apiclient.CreateOrUpdateDaemonSet(client, kubeproxyDaemonSet)
Expand Down

0 comments on commit c843d96

Please sign in to comment.