Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Unit Type Selection #308

Open
zackpyle opened this issue Feb 26, 2023 · 7 comments
Open

Inconsistent Unit Type Selection #308

zackpyle opened this issue Feb 26, 2023 · 7 comments

Comments

@zackpyle
Copy link

Is your feature request related to a problem? Please describe.
You cannot select the unit type you want across all fields in Beaver Builder. This should be able to be chosen by the developer for EVERY field. (Side note: would be nice if you should also be able to set default units)

Describe the solution you'd like
Give the select option for unit type on ALL size fields

Additional context
Ex: Why on the heading module can I select font size units, but not on letter-spacing?
Screen Shot 2023-02-26 at 15 26 48

@Pross
Copy link
Collaborator

Pross commented Feb 27, 2023

You can add defaults already to most field types, for typography it has to be an array, so something like this would set the default for letter spacing to 0.6

					'typography' => array(
						'type'       => 'typography',
						'label'      => __( 'Typography', 'fl-builder' ),
						'responsive' => true,
						'preview'    => array(
							'type'      => 'css',
							'selector'  => '{node}.fl-module-heading .fl-heading',
							'important' => true,
						),
						'default' => array(
							'letter_spacing' => array(
								'length' => '0.6',
							),
						),
					),

IF we add em as an option to letter spacing you'd be able to set that too

@codente
Copy link
Contributor

codente commented Mar 20, 2023

We will be looking at this across the board but letter spacing is up first.

@codente codente added this to In Progress in Roadmap Mar 20, 2023
@zackpyle
Copy link
Author

@codente I saw that in the latest beta 👍🏻

@zackpyle
Copy link
Author

zackpyle commented May 2, 2023

I would also be nice if things like this didn't all share a single unit type
Screen Shot 2023-05-02 at 08 04 51

@zackpyle
Copy link
Author

zackpyle commented Jul 10, 2023

@codente Are things like this going to get a unit dropdown?
Screen Shot 2023-07-10 at 16 38 51

@zackpyle
Copy link
Author

@codente Really what would be awesome is a final option of custom that just turns the dropdown into a text field where we can type in our own...

@codente
Copy link
Contributor

codente commented Apr 12, 2024

@zackpyle we'd like to add something like that too but we can't do that with our current settings so requires a re-work but it's on the list of things that we want to accomplish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
In Progress
Development

No branches or pull requests

3 participants