HTTPClient force_basic_auth setting. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting is relevant when in an application that uses Almodovar and uses Webmock (>= 2.0) as http mocking library you want to ensure you’re providing proper authorisation headers on your test. With this HTTPClient will send authorisation headers in every requests and not only as a response to a 401 status code from the server (that probably during your test is something you’re not setting). FYI: nahi/httpclient@5be11cb
|
@pacoguzman thanks for this PR, where are we going to use this? Just to know more about the context |
|
Basically if we want to ensure we're providing proper authorization headers in any project that uses Almodovar > 1.2 and Webmock > 2.0 (there is an issue already opened about this problem on some apps) |
|
@pacoguzman 👍 go ahead :) |
AlfonsoUceda
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting is relevant when in an application that uses Almodovar and uses Webmock (>= 2.0) as http mocking library you want to ensure you’re providing proper authorisation headers on your test.
With this HTTPClient will send authorisation headers in every requests and not only as a response to a 401 status code from the server (that probably during your test is something you’re not setting).
FYI: nahi/httpclient@5be11cb